This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
hotfix: allowing leading slash when call r.HTML(template_name) #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sio4
changed the title
fasmat
approved these changes
Nov 27, 2021
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we allowed a leading slash in the template name when calling
r.HTML("resources/index.plush.html")which is actually not required. (as I remember it was different by versions) Also, we generated actions with or without leading slashes before. (also different bybuffaloversions.)This hotfix makes buffalo keep the behavior so the user can migrate their existing code with a small modification as possible.
fixes gobuffalo/cli#55