Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Fixed multi-homing feature and related bugs. (#2222) #2226

Merged
merged 4 commits into from
Apr 2, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Mar 24, 2022

This will fix #2222.

In brief,

  • added structure Home as an interim solution (hope to be reshaped as Group structure in v1)
  • adapted to the new structure
  • fixed bugs related to this feature and pre-existing small ambiguous things (related to routes and middleware handling)
  • renamed the function from Host() to VirtualHost() to make the name clear, and avoid conflicting with App.Options.Host.
  • added clarified function descriptions for involved functions.

More details (including the details of fixed bugs or symptoms) will be added on issue #2222 to consolidate the information/history.

fixes #2222

@sio4 sio4 added bug Something isn't working enhancement New feature or request labels Mar 24, 2022
@sio4 sio4 self-assigned this Mar 24, 2022
@sio4 sio4 requested a review from a team as a code owner March 24, 2022 16:13
@sio4
Copy link
Member Author

sio4 commented Mar 24, 2022

oops? why CI is not running?

@sio4 sio4 linked an issue Mar 25, 2022 that may be closed by this pull request
@sio4 sio4 requested a review from paganotoni March 25, 2022 13:30
@dmuriel
Copy link
Contributor

dmuriel commented Mar 28, 2022

Hey @sio4, just wanted to thank you. I appreciate the work you did in this PR.

@paganotoni
Copy link
Member

This looks good to me @sio4. I'm not sure how to run the tests against these (We're in github limbo). I wonder if you could send this to a branch within the gobuffalo/gobuffalo repo to see if that triggers the changes. Appreciate this @sio4!

@paganotoni paganotoni changed the base branch from development to main April 2, 2022 13:39
@paganotoni paganotoni changed the base branch from main to development April 2, 2022 13:40
Copy link
Member

@paganotoni paganotoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this. We can test it in development and release depending on how it behaves.

@paganotoni paganotoni merged commit f330f9b into gobuffalo:development Apr 2, 2022
@sio4
Copy link
Member Author

sio4 commented Apr 3, 2022

Thanks! I lately found your comment. :-)

@sio4 sio4 deleted the fix-multi-homing branch April 14, 2022 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Feature/Addition Host domain" #2185 was a breaking change.
3 participants