Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

using path rather than filepath for URL-ish internal expressions #2262

Merged

Conversation

sio4
Copy link
Member

@sio4 sio4 commented May 7, 2022

Internal expressions of paths should use path instead of path/filepath.

  • The main issue was on htmlAutoRenderer.Render() which calls like ir.HTML("dir\file") in Windows.
  • Added some more checks on testcases for buffalo.FS's Open().
  • Functions assetPathFor() and loadManifest() are also fixed to make their jobs clear.
  • Additionally, fixed returning error for ErrNotExist state of Open().

It should be fixed before #2259.

@sio4 sio4 added the enhancement New feature or request label May 7, 2022
@sio4 sio4 self-assigned this May 7, 2022
@sio4 sio4 requested a review from a team as a code owner May 7, 2022 06:16
@sio4 sio4 requested review from fasmat and paganotoni May 7, 2022 15:06
@sio4 sio4 enabled auto-merge (rebase) May 14, 2022 05:26
@sio4
Copy link
Member Author

sio4 commented May 14, 2022

Hi @paganotoni, could you please take a look at this PR? it is required to fix #2259.

Copy link
Member

@paganotoni paganotoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @sio4

@sio4 sio4 merged commit 1112def into gobuffalo:development May 14, 2022
@sio4
Copy link
Member Author

sio4 commented May 14, 2022

Thanks!

@sio4 sio4 deleted the fix-path-rather-than-filepath-internally branch May 14, 2022 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants