This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
removed pop logger setting that is not required to do by buffalo #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sio4
added
enhancement
paganotoni
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to configure a pop logger here. By default, the logger used for the app generated by buffalo will use the following logger if they are configured with pop middleware. This is redundant and it made the buffalo core depends on pop.
https://github.com/gobuffalo/buffalo-pop/blob/e56c88988c60c8567cb7da927354c7d734665b20/pop/popmw/tx.go#L29
Now, we completely decoupled buffalo and pop.