Piti/feat/trace on dev test #2358
Conversation
There was a problem hiding this comment.
First, even though it's not a concrete rule, it could be better if we don't rely on specific third-party packages as much as possible and we previously removed usages of pkg/errors before. See old PRs to check the history of tracing features.
I mostly agree that having a stack trace is better for debugging the user's application but supporting it from the perspective of the framework could be made with a different approach without directly supporting a specific third party. I was working on the related code before but could not make it a high priority before. It would be better if it is flexible enough, I am also considering better support of events, and I will work on it soon.
| env := c.Value("env") | ||
| return env != nil && env.(string) != "development" && env.(string) != "test" |
There was a problem hiding this comment.
the environment "test" should execute the same code set as "production" (with data for testing) and this is not acceptable.
|
Hi, please check #2361 for the current status. I just merged the PR into the v1 branch and I am going to close this PR to proceed to the next release. |
What is being done in this PR?
This PR fixes issue #1904. And fix the bug caused by one of the previous pr that trace will only appear on development but not test environment.
What are the main choices made to get to this solution?
Without traces it's much harder to debug. The doc is also misleading that we will get a trace but in fact we didn't. This PR fix that issue.
https://gobuffalo.io/documentation/request_handling/errors/#default-error-handling-development
List the manual test cases you've covered before sending this PR:
The tests are covered in unit tests.
On dev, test: when handler return error being (pkg/errors or context.Error()) if it contains stack trace then it should return that stack trace.
On other env, trace is hidden.