This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
For nulls.Time, decode empty value as NULL #2359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being done in this PR?
This PR adds a check during decoding which will return
nulls.Time
as a NULL value (i.e. its value forValid
will be false). Without this check, the value of nulls.Time{} will be:This ends up storing the value
0001-01-01 00:00:00 +0000 UTC
in the database, as opposed to a NULL value.What are the main choices made to get to this solution?
One option was to make the model
Bindable
and write a customBind()
method which could handle empty values, but the default Bind handler does so much that bypassing it seemed extreme.What was discovered while working on it? (Optional)
List the manual test cases you've covered before sending this PR:
Fizz (using Postgres):
Model:
Plush form: