Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

fix URL Prefix #2366

Closed
wants to merge 1 commit into from
Closed

fix URL Prefix #2366

wants to merge 1 commit into from

Conversation

qdongxu
Copy link

@qdongxu qdongxu commented Feb 19, 2023

This PR addresses Issue #2356.

What is being done in this PR?

Type in here a description of the changes in this PR.
The web console cannot be opened after setting a URL prefix in actions/app.go :

	appOnce.Do(func() {
		app = buffalo.New(buffalo.Options{
			Env:         ENV,
			SessionName: "_prefix_test_session",
			Prefix:      "/prefix/",
		})

The error is :

home/index.plush.html: line 5: "rootPath": unknown identifier

What are the main choices made to get to this solution?

Type in here a description of the choices made to get to this solution.

routenamer.go consider's "/" as the root path only, ignoring a URL prefix as a root path.

List the manual test cases you've covered before sending this PR:

  1. Add a prefix as above then open http://127.0.0.1:3000/prefix/ in the browser.

@qdongxu qdongxu requested a review from a team as a code owner February 19, 2023 05:22
@qdongxu qdongxu closed this Feb 19, 2023
@qdongxu
Copy link
Author

qdongxu commented Feb 19, 2023

closed as submitted to the wrong branch.

@qdongxu qdongxu deleted the fix_prefix branch February 19, 2023 05:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant