Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Moves to use gopkg.in/mail.v2 #812

Merged
merged 4 commits into from
Dec 20, 2017
Merged

Moves to use gopkg.in/mail.v2 #812

merged 4 commits into from
Dec 20, 2017

Conversation

paganotoni
Copy link
Member

This is related to #795, so far it seems not to break dependencies, but we will have to test it more extensively.

@paganotoni
Copy link
Member Author

paganotoni commented Dec 19, 2017

Just tested this by doing the following:

  • buffalo new app
  • buffalo g mailer welcome
  • changing properties
  • calling mailers.SendWelcome() from my home handler

Do you think that is ok to say moving it to mail.v2 is ok? (this feels too easy)

@paganotoni paganotoni changed the title WIP: moves to use gopkg.in/mail.v2 Moves to use gopkg.in/mail.v2 Dec 19, 2017
@markbates markbates added this to the 0.10.3 milestone Dec 19, 2017
@markbates
Copy link
Member

lol, yeah, it definitely feels too easy. :)

@stanislas-m would you mind giving this a go since you found the problem originally?

@stanislas-m
Copy link
Member

@markbates Sure, I'll test this one today. :)

Copy link
Member

@stanislas-m stanislas-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changed my Gopkg.toml to:

[[constraint]]
  branch = "task/moving-to-mailv2"
  name = "github.com/gobuffalo/buffalo"

Then: dep ensure

Buffalo compiles without error. 👍

@markbates markbates merged commit 8fd163c into development Dec 20, 2017
@markbates markbates deleted the task/moving-to-mailv2 branch December 20, 2017 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants