Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Image tag, plugin search #815

Closed
wants to merge 2 commits into from
Closed

Image tag, plugin search #815

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2017

Added imgTag for path helpers.
Changed, added plugin directory environment variable,
this limiting full path scan for plugins.

          this fix windows slow startup and full directory scan in all platform
@markbates markbates changed the base branch from master to development December 20, 2017 15:47
@markbates
Copy link
Member

markbates commented Dec 20, 2017

Closing this in favor of #817

@backy-io Thanks for the PR. There were quite a few things that needed to happen to make this PR mergeable, so I tweaked them in #817.

A quick run down of what changed was the following:

  • Fmt'd Code - there were issues with the code not being gofmt'd properly
  • There was an unused import
  • The idea of the BUFFALO_PLUGIN_PATH was great, but it broke backward compatibility, which for a point release is a no-no
  • The splitting of the PATH was regressed. Windows separates on ; and unix on :
  • All PRs need to be made against the development branch, as per the CONTRIBUTING.md file
  • Finally, I cleaned up the assets helpers to reduce duplication and added tests.

Hopefully this helps for the next time. Thanks again fore PR!

@markbates markbates closed this Dec 20, 2017
markbates added a commit that referenced this pull request Dec 20, 2017
cleaned up issues from PR: Image tag, plugin search #815
@ghost
Copy link
Author

ghost commented Dec 20, 2017

Thx for comments, it was too early commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants