This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Improve i18n middleware error messages #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stanislas-m
commented
Jan 27, 2018
stanislas-m
commented
- Wrap parsing errors
- Wrap Box errors
- Log missing or empty locale files as a Warning, not an Error (fix 500 - ERROR! no supported languages found #878)
* Wrap parsing errors * Wrap Box errors * Log missing or empty locale files as a Warning, not an Error (fix #878)
markbates
suggested changes
Jan 27, 2018
middleware/i18n/i18n.go
Outdated
| @@ -43,15 +43,20 @@ func (t *Translator) Load() error { | |||
| return t.Box.Walk(func(path string, f packr.File) error { | |||
| b, err := t.Box.MustBytes(path) | |||
| if err != nil { | |||
| log.Fatal(err) | |||
| return errors.WithStack(err) | |||
| wErr := errors.Wrapf(err, "Unable to read locale file %s", path) | |||
There was a problem hiding this comment.
Error messages in Go are suppose to start with a lower case letter. I have no idea why. :)
middleware/i18n/i18n.go
Outdated
| return i18n.ParseTranslationFileBytes(fmt.Sprintf("%sbuff%s", dir, base), b) | ||
| err = i18n.ParseTranslationFileBytes(fmt.Sprintf("%sbuff%s", dir, base), b) | ||
| if err != nil { | ||
| return errors.Wrapf(err, "Unable to parse locale file %s", base) |
There was a problem hiding this comment.
Error messages in Go are suppose to start with a lower case letter. I have no idea why. :)
middleware/i18n/i18n.go
Outdated
| log.Fatal(err) | ||
| return errors.WithStack(err) | ||
| wErr := errors.Wrapf(err, "Unable to read locale file %s", path) | ||
| log.Fatal(wErr) |
There was a problem hiding this comment.
I know this sounds silly, since there was already a log.Fatal in this code, but shouldn't we not do that since it stops execution of the app? In theory the return on the next line never gets called.
|
@markbates Thanks, it should be ok now. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.