-
-
Notifications
You must be signed in to change notification settings - Fork 578
Conversation
Considering that looks a million times better than what we have now, I’m happy! |
@paganotoni That's way better! 👍 Is it possible to have a different text, at least for the 404 Not Found page? "Something went wrong" is not the kind of error you're used to see for a page not found, in my head it sounds I've broken something. |
@stanislas-m I like that idea, will add that into this PR, agree that it's a bit odd to see an error when its actually a 404. |
@paganotoni I'm not sure the sentence about the app owner is necessary, but overall that's great! (404 errors are really common, and as an app owner I'll probably look at the logs for server errors, not 404 ones.) |
@stanislas-m @markbates I'm removing the WIP, added another flavor for 404 as @stanislas-m mentioned, give it a shot and let me know :) |
I vote we use https://http.cat photos :D |
@markbates this one is ready to be merged. |
* Adds basics styles to the production error page * Adding 404 page * adding a bit of padding to the error cards * covering one small UI issue
Given what we discussed in #930 I decided to start with this simple design for the error page, it adds some styling to it so we can have a better-looking error page for production:
(nothing fancy for now)
@markbates @stanislas-m sorry for the delay with this one, I think we can iterate from this first version, LMK if you guys want to change copy or any style you don't like.