Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Less ugly production error page #956

Merged
merged 9 commits into from
Mar 11, 2018

Conversation

paganotoni
Copy link
Member

Given what we discussed in #930 I decided to start with this simple design for the error page, it adds some styling to it so we can have a better-looking error page for production:

error-page

(nothing fancy for now)

@markbates @stanislas-m sorry for the delay with this one, I think we can iterate from this first version, LMK if you guys want to change copy or any style you don't like.

@paganotoni paganotoni requested a review from markbates March 6, 2018 13:00
@markbates
Copy link
Member

Considering that looks a million times better than what we have now, I’m happy!

@stanislas-m
Copy link
Member

@paganotoni That's way better! 👍 Is it possible to have a different text, at least for the 404 Not Found page? "Something went wrong" is not the kind of error you're used to see for a page not found, in my head it sounds I've broken something.

@paganotoni
Copy link
Member Author

paganotoni commented Mar 6, 2018

@stanislas-m I like that idea, will add that into this PR, agree that it's a bit odd to see an error when its actually a 404.

@paganotoni
Copy link
Member Author

@stanislas-m not-found

@stanislas-m
Copy link
Member

@paganotoni I'm not sure the sentence about the app owner is necessary, but overall that's great! (404 errors are really common, and as an app owner I'll probably look at the logs for server errors, not 404 ones.)

@markbates markbates added this to the 0.11.1 milestone Mar 6, 2018
@paganotoni
Copy link
Member Author

@stanislas-m @markbates I'm removing the WIP, added another flavor for 404 as @stanislas-m mentioned, give it a shot and let me know :)

@paganotoni paganotoni changed the title WIP: Less ugly production error page Less ugly production error page Mar 7, 2018
@robbyoconnor
Copy link
Contributor

I vote we use https://http.cat photos :D

@paganotoni
Copy link
Member Author

@markbates this one is ready to be merged.

@markbates markbates merged commit 8f8d0b2 into development Mar 11, 2018
@markbates markbates deleted the feature/basic-error-page-styles branch March 11, 2018 16:42
stanislas-m pushed a commit that referenced this pull request May 12, 2018
* Adds basics styles to the production error page

* Adding 404 page

* adding a bit of padding to the error cards

* covering one small UI issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants