This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
updated go version of the builder Dockerfile #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops! my force-push, after rebasing and adding one more commit to the original brach, made the pr #148 could not be reopened. :-( Sorry @paganotoni. I tried to keep your commit and PR and others' commit too but it was not perfect.
Comment from the original PR:
This is a part of gobuffalo/buffalo#2264.
All current tests for the major packages (which are used for buffalo core, buffalo CLI, pop, and the generated app by default) are passed and it looks like the generated app also working fine with g1.18 and the recent version of packages.
I think it is time to update Dockerfile for the builder.
By the way, IMO, I would like to keep the code compatible with 1.16 for a while (I mean we don't need to proactively remove compatibility code) since I think there are many users who still using 1.16 in their production. (I hope our policy for the go version could be a kind of "we officially support the last two versions of go, but it could be ok using a few more previous versions")
(two of unrelated module update is also included)