This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
improvement: using go built in build-info. #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of shelling out to get it.
sio4
approved these changes
Nov 20, 2022
| @@ -8,5 +8,5 @@ on: | |||
| jobs: | |||
| call-standard-test: | |||
| name: Test | |||
| uses: gobuffalo/.github/.github/workflows/go-test.yml@v1 | |||
| uses: gobuffalo/.github/.github/workflows/go-test.yml@v1.6 | |||
There was a problem hiding this comment.
After the next core release I am preparing nowadays, I will update the tag v1 to point v1.6 so all packages will use the versions! Thanks!
|
I have some action items on Pop and Core. After finishing them, I would like to update the CLI dependencies and will prepare the next version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes how we find the VCS part of the build info. It uses Go runtime/debug instead of shelling out to determine it.
Which are the main considerations
One important consideration is the version of Go, Buffalo supports the last 2 versions, and Go latest version is 1.19 (1.20 coming soon). The library used is available since Go 1.18 so we should be good to go.
How did you test this?
I installed this new version of the CLI and make sure that after I compiled my binary it got the build info there by running:
Did you discover anything while on this?
While on this one I discovered that the template workflows have versions. I had to tag a new version for the standard go tests (v1.6) on the .github repo and make this branch use it. That new version has the versions set to 1.18 and 1.19.