This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Generate embed.go files with hot reload enabled #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
changed the title
Improve integration testing and add fixers for 0.17.x -> 0.18.x
Refactor existing tests to use genny instead of fixtures
Nov 27, 2021
fasmat
changed the title
Refactor existing tests to use genny instead of fixtures
Generate embed.go files with hot reload enabled
Nov 27, 2021
LGTM! tested along with updated gobuffalo/buffalo#2180 |
@paganotoni This PR is now ready to be merged 😄 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some of the existing tests and adds templates for the new
embed.go
files that allow for hot reloading. This is the follow up togobuffalo/buffalo#2180