Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for routing Host introduced in 0.18.2 #605

Merged
merged 3 commits into from
Dec 24, 2021
Merged

Add documentation for routing Host introduced in 0.18.2 #605

merged 3 commits into from
Dec 24, 2021

Conversation

saurori
Copy link
Contributor

@saurori saurori commented Dec 16, 2021

The Host function was introduced in v0.18.2 from this PR.

I've added documentation for English and attempted a translation to French via Google Translate.

dmuriel
dmuriel previously approved these changes Dec 16, 2021
Copy link
Contributor

@dmuriel dmuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saurori for the documentation, I like it.

templates/fr/docs/routing/_hosts.md Outdated Show resolved Hide resolved
templates/fr/docs/routing/_hosts.md Outdated Show resolved Hide resolved
templates/en/docs/routing/_hosts.md Outdated Show resolved Hide resolved
@stanislas-m stanislas-m merged commit 93bd3b6 into gobuffalo:master Dec 24, 2021
@stanislas-m
Copy link
Member

Thanks @saurori!

@saurori saurori deleted the routing-hosts branch December 24, 2021 16:00
@saurori
Copy link
Contributor Author

saurori commented Feb 9, 2022

@stanislas-m just a heads up, the deployment failed: https://github.com/gobuffalo/docs/deployments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants