Fix capitalization for non-English strings #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Capitalizeimplementation is broken for non-English strings. I didn't dive deep into analysis of the problem, but the problem seems to appear in the concatenation ofi.Original[1:]to the capitalized letter. It works only under assumtion that rune of the first character takes exactly 1 byte, which is not true for non-English UTF-8 encoded strings.My version assumes that capitalized letter should be of the same size as non-capitalized, and just replaces it. I'm not quite sure it's always the case, but should be for most common usages if the first character is a Letter.