Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "vice" -> "vices" suffix, for "services" and "devices" #50

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

StephenBrown2
Copy link
Contributor

@StephenBrown2 StephenBrown2 commented Jan 29, 2021

Adds a new suffix and test cases to ensure words "service" and "device" are properly pluralized to "services" and "devices", as noted in two current issues.

Also sorts and uniquifies the singlePluralAssertions slice in flect_test.go

Duplicates removed:

	{"analysis", "analyses"},
	{"bus", "buses"},
	{"child", "children"},
	{"datum", "data"},
	{"mouse", "mice"},
	{"movie", "movies"},
	{"ox", "oxen"},
	{"person", "people"},
	{"photo", "photos"},
	{"series", "series"},
	{"species", "species"},
	{"tomato", "tomatoes"},

Separated into two commits to show failing tests representing the issues, and the resolving fix with successful tests.

Fixes #44
Fixes #49

Copy link

@max-koehler max-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update on the topic?

@benjaminjb
Copy link

Any update on this topic? Big fan of the alphabetizing

@servusdei2018
Copy link

/cc @paganotoni

@paganotoni
Copy link
Member

LGTM! Thanks!

@paganotoni paganotoni merged commit cc5b892 into gobuffalo:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singular form of “services” is not “servex” Resource Named Param and Routes change after upgrade
5 participants