-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return 401 in all cases of failure #3
Conversation
The tests are failing for this, can you please take a look? Thanks. |
f390cb2
to
75d6a39
Compare
Thanks for the contributing link, should have checked this before making the PR 😇 |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, and sorry for the late review.
Could you please check the comments and fix them? I will proceed with this PR after that.
If you have no interest in this module anymore, not sure since it is already more than four years ago, just ignore this message. I will work on it soon.
fad503a
to
0b7b952
Compare
In some cases buffalo would return a 500 instead of a 401 when the authorization fails. This commit should fix this behavior, see discussion in Slack: https://gophers.slack.com/archives/C3MSAFD40/p1543923920092000
0b7b952
to
10445ab
Compare
Thanks for picking this up! Rebased, pushed, realized two commits, squashed them and all of the requested changes should be included by now 🤞 |
all the reviews were addressed and Mark is not actively work on here nowadays
Thanks! |
Just for your information, I made some more changes to the topic and filed PR #7. Just in case you are interested. |
In some cases buffalo would return a 500 instead
of a 401 when the authorization fails.
This commit should fix this behavior, see
discussion in Slack:
https://gophers.slack.com/archives/C3MSAFD40/p1543923920092000