Merge pull request #183 from Mido-sys/fix_division_zero_issue_182

Gracefully handle division by zero using ints & floats

compiler.go

@@ -530,6 +530,9 @@ func (c *compiler) intsOperator(l int, r int, op string) (interface{}, error) {
 	case "-":
 		return l - r, nil
 	case "/":
+		if r == 0 {
+			return nil, fmt.Errorf("division by zero %v %s %v", l, op, r)
+		}
 		return l / r, nil
 	case "*":
 		return l * r, nil
@@ -556,6 +559,9 @@ func (c *compiler) floatsOperator(l float64, r float64, op string) (interface{},
 	case "-":
 		return l - r, nil
 	case "/":
+		if r == 0 {
+			return nil, fmt.Errorf("division by zero %v %s %v", l, op, r)
+		}
 		return l / r, nil
 	case "*":
 		return l * r, nil

math_test.go

@@ -8,6 +8,24 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func Test_Render_Int_Math_Division_By_Zero(t *testing.T) {
+	r := require.New(t)
+	input := `<%= 10 / 0 %>`
+	s, err := plush.Render(input, plush.NewContext())
+	r.Error(err)
+	r.Empty(s)
+	r.Contains(err.Error(), "division by zero 10 / 0")
+}
+
+func Test_Render_Int_Float_Division_By_Zero(t *testing.T) {
+	r := require.New(t)
+	input := `<%= 10.5 / 0.0 %>`
+	s, err := plush.Render(input, plush.NewContext())
+	r.Error(err)
+	r.Empty(s)
+	r.Contains(err.Error(), "division by zero 10.5 / 0")
+}
+
 func Test_Render_Int_Math(t *testing.T) {
 	r := require.New(t)