Merge pull request #131 from Mido-sys/fix_if_condition_if_variable_set

return true if the names variable is set

compiler.go

@@ -200,10 +200,6 @@ func (c *compiler) evalIfExpression(node *ast.IfExpression) (interface{}, error)
 		}
 	}
 
-	if !c.isValidIfCondtionValue(con) {
-		return nil, fmt.Errorf("non-bool %s (type %T) used as if condition", node.Condition.String(), con)
-	}
-
 	if c.isTruthy(con) {
 		return c.evalBlockStatement(node.Block)
 	}
@@ -231,16 +227,7 @@ func (c *compiler) evalElseAndElseIfExpressions(node *ast.IfExpression) (interfa
 	}
 	return r, nil
 }
-func (c *compiler) isValidIfCondtionValue(i interface{}) bool {
 
-	switch i.(type) {
-	case bool, nil:
-		return true
-
-	default:
-		return false
-	}
-}
 func (c *compiler) isTruthy(i interface{}) bool {
 	if i == nil {
 		return false

if_test.go

@@ -6,20 +6,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func Test_Render_If_Condition_Not_Valid(t *testing.T) {
-	r := require.New(t)
-	input := `<% 
-	
-		if (x - 4) { 
-			return "hi"
-		} %>`
-	ctx := NewContext()
-	ctx.Set("x", 4)
-
-	s, err := Render(input, ctx)
-	r.Error(err)
-	r.Equal("", s)
-}
 func Test_Render_If(t *testing.T) {
 	r := require.New(t)
 	input := `<% if (true) { return "hi"} %>`
@@ -255,3 +241,22 @@ func Test_If_String_Truthy(t *testing.T) {
 	r.NoError(err)
 	r.Equal("<p>hi</p>", s)
 }
+
+func Test_Render_If_Variable_Is_Set(t *testing.T) {
+	r := require.New(t)
+	input := `<%= if (names) { %>hi<%} %>`
+	ctx := NewContext()
+	ctx.Set("names", "123")
+	s, err := Render(input, ctx)
+	r.NoError(err)
+	r.Equal("hi", s)
+}
+
+func Test_Render_If_Variable_Not_Set(t *testing.T) {
+	r := require.New(t)
+	input := `<%= if (names) { %>hi<%} %>`
+
+	s, err := Render(input, NewContext())
+	r.NoError(err)
+	r.Equal("", s)
+}