Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line comments #114

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Line comments #114

merged 2 commits into from
Oct 27, 2021

Conversation

duckbrain
Copy link
Contributor

@duckbrain duckbrain commented Aug 14, 2020

Adds line comments by skipping them in the lexer.

I chose # because it matches up with the block comments <%# and it's used in examples in the readme.

Closes gobuffalo/fizz#45

@truesilver92
Copy link

@paganotoni Will you review this?

@paganotoni
Copy link
Member

This looks good. Thanks @truesilver92

@paganotoni paganotoni merged commit c2f85ef into gobuffalo:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support '//' comments
3 participants