Render bin #20
Render bin #20
Conversation
|
Damn. Something changed in master in past few days because of which this is failing. Will fix and push. |
For some reason, intelliJ won't fire gofmt.
There was a problem hiding this comment.
I love this PR, but there are a few things to note before it can be merged.
- It breaks the existing functionality of the
plushcommand. Before you could do something likeplush foo.plushand it would work, now it raises an error:
Error: unknown command "foo.plush" for "plush"
Run 'plush --help' for usage.
unknown command "foo.plush" for "plush"
That needs to be fixed before this can be merged.
-
It would be great if the flags also applied to running scripts as well as templates.
-
The current functionality of the
plushcommand is to run scripts, i.e. "raw" plush. This command adds the ability to run a template. Perhaps they be combined with a flag? Or some other way of distinguishing the two. -
Plush using the https://godoc.org/github.com/stretchr/testify/require library for testing, so if you could please keep with the coding style of the project that would be excellent.
Again, overall I love the idea of this, but we need to fix these few things first before we can merge it. Thanks.
|
Never updated... very nice... tzzz... |
|
Closing due to lack of progress. |
Fixes #5