Allow default block for contentOf
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @ruudk - sorry for breaking it. |
markbates
suggested changes
Jun 15, 2018
| for k, v := range data { | ||
| ctx.Set(k, v) | ||
| } | ||
| body, err := help.BlockWith(ctx) |
There was a problem hiding this comment.
The block shouldn't be required. Currently this code will return an error if there is no block, which isn't the expected behavior of contentOf. You should check to see if there is a block first, before trying to run it.
There was a problem hiding this comment.
Hmm, but how come the tests pass?
Now I get it! Will fix it.
ruudk
force-pushed
the
default-content-of
branch
from
6557ebd to
3ea790b
Compare
|
What's needed to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57