added partial helper #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbates
suggested changes
Oct 31, 2018
partial_helper.go
Outdated
| help.Context.data[k] = v | ||
| } | ||
|
|
||
| pf, ok := help.Context.data["partialFeeder"].(func(string) (string, error)) |
There was a problem hiding this comment.
Type check against PartialFeeder here
There was a problem hiding this comment.
Can I just use below here?
var pf PartialFeeder
I think it is just func(string) (string, error) so if the interface data["partialFeeder"] not match, it will not ok anyway.
|
I’ll test this in a few hours when my day officially starts. :) Can you write or test or two? |
|
Oh, I also think the same thing and I like test as much as buffalo (and your test kits) :-) |
markbates
approved these changes
Oct 31, 2018
partial_helper.go
Outdated
| help.Context.data[k] = v | ||
| } | ||
|
|
||
| pf, ok := help.Context.data["partialFeeder"].(func(string) (string, error)) |
There was a problem hiding this comment.
Suggested change
| pf, ok := help.Context.data["partialFeeder"].(func(string) (string, error)) | |
| pf, ok := help.Context.data["partialFeeder"].(PartialFeeder) |
markbates
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @markbates, and all buffalo lovers
I added plush's own partial helper. It does not directly affect any of applications using plush because of it just add new things. But for buffalo, the order to fill
data/helperis important since it can be overrided by one of them. (Please consider minor version changing if needed.)For references:
It related to issue "context not passed when
partialused withinforloop" (gobuffalo/buffalo#1406) and should be merged before PR for buffalo (gobuffalo/buffalo#1411) which depends on this change.