Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent parent context changes #76

Merged
merged 2 commits into from
Nov 17, 2018

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Nov 15, 2018

I found a bug on partialHelper which is if the partial changes some context value internally, it affects caller's context. This PR added new local context for partial handling and isolate partial processing from the parent's context.

@markbates markbates merged commit 843ce47 into gobuffalo:master Nov 17, 2018
@sio4 sio4 deleted the partial-value-changed branch November 19, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants