Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @markbates and @stanislas-m,
I open a PR to fix the behavior of plush when we call a method of structure which has pointer receiver.
(related to gobuffalo/buffalo#1479)
When the model looks like
and we wrote templates like
in
show.html
which isrobot
is already a pointer orin
index.html
which isrobot
in the loop is not a pointer.Currently, the first template works fine as user expected but the code was translated into the same result of
robot.String()
in second template. If this is not a designed behavior(I think so), this PR makes the same results from these two cases.