Convert models generator to Genny #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 28, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
ghost
reviewed
Mar 11, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
stanislas-m
requested changes
Apr 3, 2019
mclark4386
reviewed
Apr 3, 2019
mclark4386
reviewed
Apr 3, 2019
stanislas-m
force-pushed
the
generators
branch
from
833fb8e to
0d8b442
Compare
stanislas-m
force-pushed
the
generators
branch
2 times, most recently
from
ce2285d to
bc5f8d3
Compare
Almost done refactor model generator command line.
stanislas-m
force-pushed
the
generators
branch
from
332b641 to
79a0eac
Compare
stanislas-m
changed the title
stanislas-m
approved these changes
Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the legacy model generator (which still uses Makr) to use Genny instead.
The aim is to make it more testable, and serve as a base for future improvements.