moves a few 3rd party deps into the internal package. this reduces dependencies. #399
Conversation
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
| return s1 | ||
| } | ||
|
|
||
| func Int(i1, i2 int) int { |
There was a problem hiding this comment.
exported identifier "Int" should have comment
| func Int(i1, i2 int) int { | |
| // Int ... | |
| func Int(i1, i2 int) int { |
| return i1 | ||
| } | ||
|
|
||
| func Int64(i1, i2 int64) int64 { |
There was a problem hiding this comment.
exported identifier "Int64" should have comment
| func Int64(i1, i2 int64) int64 { | |
| // Int64 ... | |
| func Int64(i1, i2 int64) int64 { |
| return i1 | ||
| } | ||
|
|
||
| func Float32(i1, i2 float32) float32 { |
There was a problem hiding this comment.
exported identifier "Float32" should have comment
| func Float32(i1, i2 float32) float32 { | |
| // Float32 ... | |
| func Float32(i1, i2 float32) float32 { |
| return i1 | ||
| } | ||
|
|
||
| func Float64(i1, i2 float64) float64 { |
There was a problem hiding this comment.
exported identifier "Float64" should have comment
| func Float64(i1, i2 float64) float64 { | |
| // Float64 ... | |
| func Float64(i1, i2 float64) float64 { |
|
|
||
| var deprecationWriter io.Writer = os.Stdout | ||
|
|
||
| func Deprecate(depth int, name string, msg string) { |
There was a problem hiding this comment.
exported identifier "Deprecate" should have comment
| func Deprecate(depth int, name string, msg string) { | |
| // Deprecate ... | |
| func Deprecate(depth int, name string, msg string) { |
|
|
||
| var deprecationWriter io.Writer = os.Stdout | ||
|
|
||
| func Deprecate(depth int, name string, msg string) { |
There was a problem hiding this comment.
two or more consecutive named function parameters share a type, you can omit the type from all but the last
| func Deprecate(depth int, name string, msg string) { | |
| func Deprecate(depth int, name, msg string) { |
|
|
||
| var onces = &sync.Map{} | ||
|
|
||
| func Do(name string, fn func()) { |
There was a problem hiding this comment.
exported identifier "Do" should have comment
| func Do(name string, fn func()) { | |
| // Do ... | |
| func Do(name string, fn func()) { |
| } | ||
| } | ||
|
|
||
| func Reset(names ...string) { |
There was a problem hiding this comment.
exported identifier "Reset" should have comment
| func Reset(names ...string) { | |
| // Reset ... | |
| func Reset(names ...string) { |
No description provided.