Prevent CockroachDB TruncateAll from emptying the migration table #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mclark4386
approved these changes
Oct 6, 2019
|
Thanks! |
breml
added a commit
to breml/pop
that referenced
this pull request
Apr 20, 2020
Bring dialect mysql on par with postgres and cockroachDB. See: gobuffalo#443
stanislas-m
added a commit
that referenced
this pull request
Apr 20, 2020
Bring dialect mysql on par with postgres and cockroachDB. See: #443 Co-authored-by: Stanislas Michalak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TruncateAll() func in PostgreSQL dialect doesn't truncate the migration table so I think CockroachDB shouldn't truncate it either.
I was using PostgreSQL previously and I used TruncateAll() in my
db:seedtask. With CockroachDB the samedb:seedtask messes up the database migrations in development environments.