Use pkg name in tableMap for unique cache keys #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using two structs from different packages where both structs have the same name as models, the `tableMap` would incorrectly set up as only the struct's name is used as the cache key. This patch uses the package path and the struct name to generate unique cache keys across go projects. Closes gobuffalo#477 Signed-off-by: aeneasr <[email protected]>
|
@stanislas-m this supersedes #478 . I've also added a failing test case to prevent future regressions. |
stanislas-m
approved these changes
Nov 29, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using two structs from different packages where both structs have the same name as models, the
tableMapwould incorrectly set up as only the struct's name is used as the cache key.This patch uses the package path and the struct name to generate unique cache keys across go projects.
Closes #477