Resolve several panics, incorrect reflection uses, and eager bugs #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a panic where `EagerPreload` tried to set `reflect.Struct` for a `reflect.Pointer` on 1.. associations. Signed-off-by: aeneasr <[email protected]>
aeneasr
changed the title
EagerPreload panic caused for pointer referencesEagerPreload panic caused by pointer references
Resolves a panic where `EagerPreload` was trying to set UUID into NullUUID. Signed-off-by: aeneasr <[email protected]>
Resolves an issue where n+1 eager associations would error with a double pointer in `associations.ForStruct`. Signed-off-by: aeneasr <[email protected]>
Signed-off-by: aeneasr <[email protected]>
Signed-off-by: aeneasr <[email protected]>
aeneasr
changed the title
EagerPreload panic caused by pointer references
aeneasr
force-pushed
the
fix-panics-preload
branch
from
81ed83b to
bbf58e6
Compare
…n keys Closes #139 Signed-off-by: aeneasr <[email protected]>
aeneasr
force-pushed
the
fix-panics-preload
branch
from
bbf58e6 to
f877758
Compare
Signed-off-by: aeneasr <[email protected]>
Signed-off-by: aeneasr <[email protected]>
Signed-off-by: aeneasr <[email protected]>
Signed-off-by: aeneasr <[email protected]>
Signed-off-by: aeneasr <[email protected]>
|
Ready for 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a panics, incorrect eager loading, and reflection bugs.