do not swallow panic when rolling back inner panic to prevent connection leak #797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Transaction()
not swallow inner panic when rolling back inner panic to prevent connection leak. (followup for #748, #775)fixes #793
With this configuration,
Previously we got a generic error but no information about the actual panic:
now, the panic message will be handled by Buffalo's panic handler (or the application using Pop just gets the panic)
Developers can use https://github.com/gobuffalo/events/ for more details:
(
Payload
has a bug having additional "data", and will be fixed soon)The above code will print the following: