Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed empty slice bug on slices.Float #798

Merged
merged 1 commit into from
Nov 19, 2022
Merged

fixed empty slice bug on slices.Float #798

merged 1 commit into from
Nov 19, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Nov 19, 2022

This bug is related to #791 and #788 but for Float. Copied the Int version and added an integration test for PostgreSQL.

@sio4 sio4 added the bug Something isn't working label Nov 19, 2022
@sio4 sio4 added this to the v6.1.0 milestone Nov 19, 2022
@sio4 sio4 requested a review from a team November 19, 2022 06:17
@sio4 sio4 self-assigned this Nov 19, 2022
sio4
sio4 commented Nov 19, 2022
View reviewed changes
Copy link
Member Author

@sio4 sio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the same approach from the PR #791

@sio4 sio4 enabled auto-merge November 19, 2022 06:23
@sio4 sio4 merged commit 479087d into main Nov 19, 2022
@sio4 sio4 deleted the empty-slice branch November 19, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paganotoni paganotoni paganotoni approved these changes

Assignees

@sio4 sio4

Labels
bug Something isn't working
Projects
None yet
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sio4 @paganotoni