Use gobuffalo/flect instead of markbates/inflect #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tests are failing for label generation for
"GaveAThing". This was working with flect, as in this case it basically treatedAas an acronym (multiple uppercase letters get split at the last one) and separated it from the rest (returning"Gave A Thing"). Inflect is handling this in a different way and treats it as"Gave AThing".I'm not sure which one is the expected result. I don't think the approach of flect is good (on the matter of how it's done), but on the other hand this is a breaking change and removes the ability of creating single char words in labels.
@markbates @paganotoni, what are your opinions on this?