Fix a11y problems with validation error messages generated by Bootstrap form_for #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being done in this PR?
This fixes the accessibility issue described in #146
What are the main choices made to get to this solution?
It doesn't seem to be possible to work around the problem without changes to the tag code.
Hence the code was patched to generate unique IDs for the error messages, and associate them with the input field using
aria-describedby.In addition, the invalid field now has the
aria-invalidattribute added.List the manual test cases you've covered before sending this PR:
Test cases in
form_for_test.goare updated.