DynGd trait support + FromGodot "re-enrichment" conversions
#958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows polymorphic conversion of of Gd<T> to DynGd<T, D> (without direct AsDyn relation, only through derived classes). Co-authored-by: Yarvin <[email protected]>
Also unit-test each of them.
Bromeon
added
feature
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-958 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #953.
Many thanks to @Yarwin, who supported me throughout the design + implementation phase (also with great ideas from #930), and helped a lot with testing! 💪
This enhances the bare-bones #953 with a ton of traits to integrate with Godot, most notably:
DebugDisplayEq+PartialEq+Hash(reference semantics likeGd)ToGodot,GodotConvert(pass as object to Godot)FromGodot(hard*)ArrayElementAsArg+ParamType.The
DynGdAPI is extended to includecast+try_cast, as well as a lot more documentation.Also improves some error messages for existing conversions.
*
FromGodotwas particularly difficult, because we need to obtain adyn Traitpointer from the aether (Godot doesn't have it), and make sure it points to the correctimpl Traitvtable. Thanks again for the digging, Yarwin!