Remove performance comparison from C# Basics #10286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetrapod00
added
topic:dotnet
area:manual
mhilbrunner
approved these changes
Nov 19, 2024
|
Personally I'd just remove the entire paragraph. As I mentioned in the original PR1, I think it feels out of place to bring up other languages in the C# documentation, and I don't feel like the comparison is comprehensive enough to be accurate. Footnotes |
|
Removing the whole paragraph is fine by me. I made a separate PR #10287 to bring the comparison to the FAQ, and that can be linked to from the C# performance section. |
|
I'm likewise in favor of going ahead with #10287 and removing this. |
tetrapod00
force-pushed
the
4x-csharp
branch
from
f1d031b to
77f3eb6
Compare
tetrapod00
changed the title
|
Snip! Updated this PR to remove the performance comparison paragraph entirely. Performance comparison is being moved and expanded in the other PR. |
skyace65
approved these changes
Nov 20, 2024
|
Thanks! |
|
Cherrypicked to 4.3 in #10347. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #7538.
In that original PR, there was reasonable consensus to at least remove the claim that C# is 4x faster than GDScript.
I still think a larger comparison of the performance of C#, GDScript, and C++ is warranted, and it should be somewhere other than the C# section of the docs. Those changes are for another PR.