Mark Script button if it's tool in Scene Tree Editor #65088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
the
cherrypick:3.x
|
The concept looks good, but I'd probably use a less saturated color as it seems a bit extreme to me right now. |
|
In that case it should be less saturated on the script list, as well? Just as a matter of consistency? |
|
Now, no extra saturation is applied, it looks like this: |
Mickeon
force-pushed
the
editor-scene-tree-tool-icon
branch
from
112ebd9 to
ddfbb24
Compare
akien-mga
reviewed
Sep 1, 2022
Also adds a note on the tooltip if the Script is tool. The color is the same one used on the Script Editor's script list.
Mickeon
force-pushed
the
editor-scene-tree-tool-icon
branch
from
ddfbb24 to
ad5ff9f
Compare
akien-mga
approved these changes
Sep 1, 2022
|
Thanks! |
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
This was referenced Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recall there was a proposal mentioning this, but I don't remember what it was.
This PR... uh... Images speak louder than words...
Also adds a note on the tooltip if the Script is tool.
The color is the same one used on the Script Editor's script list: a very saturated accent color.