Fix wrong android key mapping. #68287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the wrong mapping of `Key::HOME`. Androids `KEYCODE_HOME` is in fact the hardware home button the right mapping is `KEYCODE_MOVE_HOME`. Also adds mappings to keys that were not present before.
HolonProduction
force-pushed
the
android_keys
branch
from
05da87d to
a3f0dc5
Compare
thebestnom
approved these changes
Nov 5, 2022
akien-mga
approved these changes
Nov 6, 2022
akien-mga
added
the
cherrypick:3.x
|
Thanks! |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the wrong mapping of
Key::HOME. Android'sKEYCODE_HOMEis in fact the hardware home button the right mapping isKEYCODE_MOVE_HOME.Also adds mappings to keys that were not present before.