[3.x] Add alignment options to flow container #68556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometror
reviewed
Nov 12, 2022
|
Thanks! |
hhyyrylainen
added a commit
to Revolutionary-Games/Thrive
that referenced
this pull request
Jan 9, 2023
sadly they can't be center aligned before Godot 3.6 because of: godotengine/godot#68556
hhyyrylainen
added a commit
to Revolutionary-Games/Thrive
that referenced
this pull request
Jan 12, 2023
* Updated submodule * Started on making the main menu GUI navigable * Fixed SlideScreen always consuming left and right inputs * Fixed returning from the social icons doesn't fully work well for sub menus but that can be fixed later, probably * Made a bunch of GUI work on a basic level with a controller with most menus now at least allowing exiting with a controller * Fixed GUI focus setter not running when paused * Did some bare minimum controller navigation for the editor and improved new save menu navigation a bit * Added controller button icons and started on input method detection and displaying of the relevant icons * Added initial connected controller detection * Turned on mipmaps for the xelu prompts and added import settings for the new ones * First part of a general tab control for controllers done doesn't yet correctly switch between tabs with the buttons * Reverted the testing changes in GalleryViewer.tscn * Stop translations trying to translate the tab indicators * Added a few input actions that don't affect the control method * Implemented the left and right inputs for the tabs control * Tweaked controller navigation a bit for the mod manager and Thriveopedia.tscn * Got new game menu tab buttons working with a controller sadly they can't be center aligned before Godot 3.6 because of: godotengine/godot#68556 * Started on options menu controller navigation * Made custom checkbox have a focus style even when it is pressed * Made the options menu basically controller navigable * Reduced tab switch indicator button prompt sizes and added skipping hidden tab buttons when going forward or back * Skip disabled in tab buttons, adjusted the layout, allow hidden in editor children * Converted some editors to use the new tabs * Tweaked the options menu tabs but didn't get them to look nice yet * Options menu tabs buttons are now pretty well positioned still could be improved when Godot 3.6 comes and tabs can be centered * Added new tab system use for the remaining editors * Added some GUI practices documentation
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport to Godot 3.x of the following PR #67788.
The implementation looks a bit different in order to align it better (haha get it?) to Godot 3.x's BoxContainer align implementation. I have also checked
project_converter_3_to_4and, from my understanding, it is already prepared to rename the enums to the Godot 4 version, as it would use the same logic as for the BoxContainer part. So no changes would be needed in that depart.Please let me know if there is anything else that could be done to improve this feature.