Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Whitescreen Issue in GLES2.0 Glow Setting #74953

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

Khejanin
Copy link

@Khejanin Khejanin commented Mar 15, 2023

Fixes #74932
Replaced textureLod with texture2DLod in the tonemapping.glsl shader file

Replaced textureLod with texture2DLod in the tonemapping.glsl shader file.
@Khejanin Khejanin requested a review from a team as a code owner March 15, 2023 19:36
@clayjohn
Copy link
Member

Can you confirm that you tested locally and #74932 is indeed fixed?

@Khejanin
Copy link
Author

@clayjohn Yes I've tested it locally and can confirm that the issue is fixed, here's a screenshot:
image

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you for confirming

@lawnjelly lawnjelly merged commit ab4d76e into godotengine:3.x Mar 19, 2023
@lawnjelly
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Apr 12, 2023
@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants