[3.x] Augment the InputEvent class with a CANCELED state
#76715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
force-pushed
the
add_input_event_cancelled_state_3x
branch
3 times, most recently
from
be12f6d to
88f4e88
Compare
m4gr3d
force-pushed
the
add_input_event_cancelled_state_3x
branch
5 times, most recently
from
f48c4d7 to
aee9b68
Compare
akien-mga
reviewed
May 8, 2023
m4gr3d
force-pushed
the
add_input_event_cancelled_state_3x
branch
from
aee9b68 to
5e0ae5e
Compare
m4gr3d
changed the title
InputEvent class with a CANCELLED stateInputEvent class with a CANCELED state
|
@RandomShaper @akien-mga Ping on the 3.x version for #76719 |
m4gr3d
force-pushed
the
add_input_event_cancelled_state_3x
branch
2 times, most recently
from
fb934e1 to
12c8cee
Compare
The `InputEvent` class currently supports the `pressed` and `released` states, which given the binary nature, is represented by a `bool` field. This commit introduced the `CANCELED` state, which signals that an ongoing input event has been canceled. To represent all the states, the `InputEventState` enum is added and the `InputEvent` logic is refactored accordingly.
m4gr3d
force-pushed
the
add_input_event_cancelled_state_3x
branch
from
12c8cee to
94d6c3d
Compare
akien-mga
approved these changes
May 17, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InputEventclass currently supports thepressedandreleasedstates, which given the binary nature, is represented by aboolfield.This PR introduces the
CANCELEDstate, which signals that an ongoing input event has been canceled.To represent all the states, the
InputEventStateenum is added and theInputEventlogic is refactored accordingly.Fixes #75144
Address #74199
main version