[3.x] Fix PopupMenu's automatic max height
#77691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
regression
topic:gui
cherrypick:3.5
akien-mga
approved these changes
Jun 7, 2023
akien-mga
changed the title
PopupMenu's automatic max heightPopupMenu's automatic max height
|
Thanks! |
akien-mga
removed
the
cherrypick:3.5
|
This regression seems to introduce clipping in my UI, and I'm not sure how to rectify it. Here is my PopupMenu in Godot 3.6:
Here is the same PopupMenu in Godot 3.5.3:
It looks like all the buttons have been shifted up within the popup menu, introducing whitespace at the bottom and clipping at the top. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76289.
PopupMenus now have an implicit maximum height set to the current window height, mimicking the current behavior on 4.0.