fix(minio): close object after GetObject has returned

[NuttyShrimp]

This prevents a goroutine leak by the minio client from happening.
I found this issue because a data retrieval endpoint kept it's minio goroutine alive.
Then I stumbled upon minio/minio-go#1508 and saw the fiber wrapper didn't close the object!

Summary by CodeRabbit

• Bug Fixes
  • Improved resource management when retrieving objects from MinIO storage by ensuring proper object closure.

[coderabbitai]

Walkthrough

The pull request introduces a minor but important change in the MinIO storage implementation. A new defer object.Close() statement is added to the Get method of the Storage struct, which ensures proper resource management by automatically closing the retrieved object after its use. This change helps prevent potential resource leaks and improves the overall robustness of the object retrieval process.

Changes

File	Change Summary
minio/minio.go	Added defer object.Close() to the Get method to ensure proper object resource cleanup

Poem

🐰 A Rabbit's Ode to Resource Care

In MinIO's realm of bytes and store,
A defer statement opens a new door
Close the object, set it free
No leaks shall escape, thanks to me!
Resource management, clean and bright ✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40a6167 and 102acc2.

📒 Files selected for processing (1)

• minio/minio.go (1 hunks)

🔇 Additional comments (1)

minio/minio.go (1)

78-78: LGTM! Properly fixes the goroutine leak.

The addition of defer object.Close() ensures proper cleanup of MinIO resources in all code paths, following the best practices recommended in MinIO issue #1508. This change effectively prevents the goroutine leak without introducing any overhead.

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[gaby]

👍 LGTM