Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go_package #350

Merged
merged 4 commits into from
Nov 7, 2017
Merged

Add go_package #350

merged 4 commits into from
Nov 7, 2017

Conversation

tomwilkie
Copy link
Contributor

The expected contents of go_package has changed, see golang/protobuf#139

This is needed to build stuff with bazel - see bazel-contrib/rules_go#836

@awalterschulze
Copy link
Member

You also need to modify the gogoproto/Makefile

protoc --gogo_out=Mgoogle/protobuf/descriptor.proto=github.com/gogo/protobuf/protoc-gen-gogo/descriptor:../../../../ --proto_path=../../../../:../protobuf/:. *.proto

And regenerate the code.

And then it should be ready for merge.

@tomwilkie
Copy link
Contributor Author

Thanks @awalterschulze, done that now.

@awalterschulze
Copy link
Member

You forgot to update the Makefile I think.

@tomwilkie
Copy link
Contributor Author

@awalterschulze should be all fixed, sorry about that.

@awalterschulze
Copy link
Member

Cool :)
Thank you for the work.

@awalterschulze awalterschulze merged commit f83204b into gogo:master Nov 7, 2017
@tomwilkie
Copy link
Contributor Author

No worries - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants