Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the query by UUID sql so that it can use the idx_task_extra_at… #20545

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jun 4, 2024

…trs_report_uuids

fixes #20505

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.30%. Comparing base (b7b8847) to head (a94921a).
Report is 216 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20545       +/-   ##
===========================================
- Coverage   67.56%   46.30%   -21.27%     
===========================================
  Files         991      247      -744     
  Lines      109181    13777    -95404     
  Branches     2719     2845      +126     
===========================================
- Hits        73768     6379    -67389     
+ Misses      31449     7068    -24381     
+ Partials     3964      330     -3634     
Flag Coverage Δ
unittests 46.30% <ø> (-21.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

@stonezdj stonezdj enabled auto-merge (squash) June 4, 2024 10:09
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit b5f7a61 into goharbor:main Jun 11, 2024
12 of 13 checks passed
mohamedawnallah pushed a commit to mohamedawnallah/harbor that referenced this pull request Jul 2, 2024
goharbor#20545)

Adjust the query by UUID sql so that it can use the idx_task_extra_attrs_report_uuids

 fixes goharbor#20505

Signed-off-by: stonezdj <[email protected]>
mohamedawnallah pushed a commit to mohamedawnallah/harbor that referenced this pull request Jul 2, 2024
goharbor#20545)

Adjust the query by UUID sql so that it can use the idx_task_extra_attrs_report_uuids

 fixes goharbor#20505

Signed-off-by: stonezdj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance Improvement Proposal for queries related with the Task Table
5 participants