Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update robot creator database scheme #20918

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Sep 11, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 66.73%. Comparing base (c8c11b4) to head (c101e2d).
Report is 276 commits behind head on main.

Files with missing lines Patch % Lines
src/server/v2.0/handler/robot.go 0.00% 10 Missing ⚠️
src/server/v2.0/handler/model/robot.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20918       +/-   ##
===========================================
+ Coverage   45.36%   66.73%   +21.36%     
===========================================
  Files         244     1047      +803     
  Lines       13333   114271   +100938     
  Branches     2719     2847      +128     
===========================================
+ Hits         6049    76258    +70209     
- Misses       6983    34134    +27151     
- Partials      301     3879     +3578     
Flag Coverage Δ
unittests 66.73% <25.00%> (+21.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/controller/robot/controller.go 57.69% <100.00%> (ø)
src/controller/scan/base_controller.go 56.93% <100.00%> (ø)
src/pkg/robot/model/model.go 60.00% <ø> (ø)
src/server/v2.0/handler/model/robot.go 0.00% <0.00%> (ø)
src/server/v2.0/handler/robot.go 5.84% <0.00%> (ø)

... and 1282 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 438d4c0 into goharbor:main Sep 14, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants