Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when using debug.Dump .Page and others in server #12309

Closed
jmooring opened this issue Mar 25, 2024 · 1 comment · Fixed by #12313
Closed

Panic when using debug.Dump .Page and others in server #12309

jmooring opened this issue Mar 25, 2024 · 1 comment · Fixed by #12313

Comments

@jmooring
Copy link
Member

Reference: https://discourse.gohugo.io/t/49029

This began with v0.123.0.

These trigger a panic:

  • debug.Dump .Page
  • debug.Dump site.Taxonomies

This does not trigger a panic:

debug.Dump "foo"
@bep bep removed the NeedsTriage label Mar 26, 2024
@bep bep self-assigned this Mar 26, 2024
@bep bep added this to the v0.124.2 milestone Mar 26, 2024
@bep bep changed the title Panic when using debug.Dump with hugo server Panic when using debug.Dump .Page and others Mar 26, 2024
@bep bep changed the title Panic when using debug.Dump .Page and others Panic when using debug.Dump .Page and others in server Mar 26, 2024
@bep bep added the Upstream label Mar 26, 2024
bep added a commit to bep/hugo that referenced this issue Mar 26, 2024
This replaces the current implementation with `json.MarshalIndent` which doesn't produce the same output, but at least it doesn't crash.

There's a bug in the upstream `litter` library. This can probably be fixed, but that needs to wait.

I have tested `go-spew` which does not crash, but it is very data racy in this context.

FIxes gohugoio#12309
bep added a commit to bep/hugo that referenced this issue Mar 26, 2024
This replaces the current implementation with `json.MarshalIndent` which doesn't produce the same output, but at least it doesn't crash.

There's a bug in the upstream `litter` library. This can probably be fixed, but that needs to wait.

I have tested `go-spew` which does not crash, but it is very data racy in this context.

FIxes gohugoio#12309
bep added a commit that referenced this issue Mar 26, 2024
This replaces the current implementation with `json.MarshalIndent` which doesn't produce the same output, but at least it doesn't crash.

There's a bug in the upstream `litter` library. This can probably be fixed, but that needs to wait.

I have tested `go-spew` which does not crash, but it is very data racy in this context.

FIxes #12309
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants