Dart Sass v1.80.1 deprecation warning

[jmooring]

Testing Dart Sass v1.80.1

WARN Dart Sass: hugo:vars:0:17: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use string.unquote instead.

Why we're getting this is unclear at the moment.

[bep]

https://sass-lang.com/documentation/breaking-changes/import/

[jmooring]

This test fails with Dart Sass v1.80.1.

// Issue #12961
func TestDartSassVars(t *testing.T) {
	t.Parallel()

	files := `
-- hugo.toml --
disableKinds = ['page','section','rss','sitemap','taxonomy','term']
-- layouts/index.html --
{{ $opts := dict "transpiler" "dartsass" "outputStyle" "compressed" "vars" (dict "color" "red") }}
{{ with resources.Get "main.scss" | css.Sass $opts }}
  {{ .Content }}
{{ end }}
-- assets/main.scss --
@use "hugo:vars" as v;
body {color: v.$color;}
`

	b := hugolib.Test(t, files, hugolib.TestOptWarn())

	b.AssertFileContent("public/index.html", "body{color:red}")
	b.AssertLogContains("! WARN  Dart Sass: hugo:vars") // failing assertion
}

The warning message generated by the above is:

WARN Dart Sass: hugo:vars:0:8: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.\nUse string.unquote instead.

https://sass-lang.com/blog/import-is-deprecated/#built-in-functions

[jmooring]

hugo/resources/resource_transformers/tocss/internal/sass/helpers.go

Lines 52 to 58 in e971b7d

	varsSlice = append(varsSlice, fmt.Sprintf("%s%s: unquote(%q);", prefix, k, v))
	}
	}
	}
	sort.Strings(varsSlice)
	varsStylesheet = strings.Join(varsSlice, "\n")
	return varsStylesheet

This solves the problem when using the Dart Sass transpiler:

				varsSlice = append(varsSlice, fmt.Sprintf("%s%s: string.unquote(%q);", prefix, k, v))
			}
		}
	}
	sort.Strings(varsSlice)
	varsStylesheet = `@use "sass:string";` + "\n" + strings.Join(varsSlice, "\n")
	return varsStylesheet
}

But the containing function (CreateVarsStyleSheet) is called when using either transpiler, so the changes above need to be specific to dart sass, but I haven't found a way to get the transpiler value ("libsass" or "dartsass") within that function.

[bep]

But the containing function (CreateVarsStyleSheet)

I guess adding some kind of identifier as the first arg to CreateVarsStyleSheet would solve it.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.