Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalink for language-roots wrong when uglyURLs is true #3179

Closed
bep opened this issue Mar 14, 2017 · 1 comment
Closed

Permalink for language-roots wrong when uglyURLs is true #3179

bep opened this issue Mar 14, 2017 · 1 comment
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.20

Comments

@bep
Copy link
Member

bep commented Mar 14, 2017

There is even a test for it:

  • So de becomes /de.html
  • Should be /de/index.html
@bep bep added the Bug label Mar 14, 2017
@bep bep added this to the v0.20 milestone Mar 14, 2017
@bep bep self-assigned this Mar 14, 2017
@bep bep mentioned this issue Mar 14, 2017
Closed
26 tasks
bep added a commit to bep/hugo that referenced this issue Mar 27, 2017
@bep
hugolib: Refactor/-work the permalink/target path logic
45eaa7f 
This is a pretty fundamental change in Hugo, but absolutely needed if we should have any hope of getting "multiple outputs" done.

This commit's goal is to say:

* Every file target path is created by `createTargetPath`, i.e. one function for all.
* That function takes every page and site parameter into account, to avoid fragile string parsing to uglify etc. later on.
* The path creation logic has full test coverage.
* All permalinks, paginator URLs etc. are then built on top of that same logic.

Fixes gohugoio#1252
Fixes gohugoio#2110
Closes gohugoio#2374
Fixes gohugoio#1885
Fixes gohugoio#3102
Fixes gohugoio#3179
Fixes gohugoio#1641
Fixes gohugoio#1989
@bep bep closed this as completed in 6bf010f Mar 27, 2017
@Lednerb Lednerb mentioned this issue Feb 11, 2020
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.20
Development

No branches or pull requests
1 participant
@bep